Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Summit Workshop - Part 2 #19

Draft
wants to merge 6 commits into
base: 2024-summit-workshop/part-1
Choose a base branch
from
Draft

Summit Workshop - Part 2 #19

wants to merge 6 commits into from

Conversation

calvincestari
Copy link
Member

Part 2 - Make the user trips badge automatically update when a trip is booked or cancelled.

  1. Add navigation bar badge for user booked trips count (reuse existing icon + badge).
  2. Add query watcher to watch list of booked trips (me query).
  3. Update the cache after successful book/cancel trip mutation response.
  4. Define local cache mutation to update user list of booked trips.

@calvincestari calvincestari changed the base branch from main to 2024-summit-workshop/part-1 September 3, 2024 22:14
AnthonyMDev
AnthonyMDev approved these changes Sep 4, 2024
View reviewed changes
final/RocketReserver/TripsBadgeView.swift
}
}

func widthMultplier() -> Double {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like there should be a way to just use the label's size here, but I don't know enough SwiftUI. Feels like there should be an equivalent to UILabel.sizeToFit().

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if you set the background of the Text as the capsule, that should automatically adjust the size.

Also guess who's still subscribed to this repo 🙃

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hahaha Hi Ellen! Thanks for the tip!

@calvincestari calvincestari marked this pull request as draft September 4, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@designatednerd designatednerd designatednerd left review comments

@AnthonyMDev AnthonyMDev AnthonyMDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calvincestari @designatednerd @AnthonyMDev